Encore: add guide to use Encore in a virtual machine #11422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a VM Even with the current doc, some people were not able to make it works in a VM, see symfony/webpack-encore#277.
Lyrkan
reviewed
Apr 14, 2019
| Encore.configureWatchOptions(watchOptions => { | ||
| watchOptions.poll = 250; // check for changes every 250 ms | ||
| }); | ||
|
|
There was a problem hiding this comment.
Maybe also add a note here about the CLI equivalent (--watch-poll)?
There was a problem hiding this comment.
Yep why not, but it means that the user will have to pass --watch-poll two times in its package.json 😕
|
Thanks @javiereguiluz and @Lyrkan, reviews have been applied :) |
|
Hugo, thanks as always for contributing these docs. We made some minor rewords while merging ... but we maintained most of your original work. |
|
Don't worry and thanks for the rewords. Next time will be better! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, ✋
As the title says, this PR add a new guide for using Encore in a virtual machine.
This is what we use on ours Symfony apps at work which run inside a Vagrant VM.
It works really fine and I thought it would be helpful to share it with other people.
Also, I've removed a sub-section in the actual doc because according to symfony/webpack-encore#277, it was not working because some additional configuration was missing (and I can confirm it because I'm one of his co-worker 😛).